Replica OBB - #503
Conversation
facebook-github-bot
added
the
CLA Signed
| #include "ReplicaSemanticScene.h" | ||
| #include "SemanticScene.h" | ||
|
|
||
| #include <Sophus/se3.hpp> |
There was a problem hiding this comment.
fatal error: Sophus/se3.hpp: No such file or directory
mathfac
left a comment
mathfac
left a comment
There was a problem hiding this comment.
Looks great! Thank you fro adding this.
Can we add e2e test as we have the test for Gibson dataset?
I noticed that even functions for reading metadata are merged, there can be other code preventing from loading data correctly. For example, logic how we choose annotation data files.
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 59.81% 59.45% -0.36%
==========================================
Files 158 160 +2
Lines 7104 7167 +63
Branches 84 84
==========================================
+ Hits 4249 4261 +12
- Misses 2855 2906 +51
Continue to review full report at Codecov.
|
| return cpu_ibo_; | ||
| } | ||
|
|
||
| const std::vector<uint16_t> getObjectIdsBufferObjectCPU() const { |
There was a problem hiding this comment.
did you mean to return a ref here?
There was a problem hiding this comment.
Yes I did, thank you!
| quadCenter += vbo[ibo[fid + i]] / 6; | ||
| } | ||
|
|
||
| CORRADE_VERIFY(obj->obb().contains(quadCenter, 5e-2)); |
There was a problem hiding this comment.
With #505 merged, you can now use CORRADE_ITERATION() to have an actually usable diagnostic when something fails. For example:
for (const auto& obj : scene.objects()) {
if (obj == nullptr)
continue;
const auto& stringId = obj->id();
const int id = std::stoi(stringId.substr(stringId.find_last_of("_") + 1));
CORRADE_ITERATION(stringId);
for (uint64_t fid = 0; fid < ibo.size(); fid += 6) {
CORRADE_ITERATION(fid);
…There was a problem hiding this comment.
Ooo yay. I wanting to use that but wasn't in our repo yet.
* Add replica OBB loading
6 participants
Motivation and Context
Add Replica OBB parsing.
How Has This Been Tested
Via the test