Add GenericWriter and raw bytes mode for verbatim VRS stream copying#358
Open
danielyan86129 wants to merge 2 commits intomainfrom
Open
Add GenericWriter and raw bytes mode for verbatim VRS stream copying#358danielyan86129 wants to merge 2 commits intomainfrom
danielyan86129 wants to merge 2 commits intomainfrom
Conversation
Differential Revision: D95732614
Summary: - Add PyGenericWriter class that extends vrs::Recordable to write raw bytes without predefined DataLayout definitions - Add createGenericStream() to VRSWriter for creating generic streams by numeric RecordableTypeId - Add raw bytes mode to Reader that captures decompressed record payload as raw bytes via processRecordHeader, skipping content block parsing - Add Python bindings for GenericWriter (create_raw_record, set_tag, set_compression, get_stream_id) and Reader (set_raw_bytes_mode, get_raw_bytes_mode) - Add VRSGenericStream Python wrapper and VRSRecord.raw_record_bytes / has_raw_record_bytes properties - Add multi_stream.vrs test data and comprehensive tests covering imports, stream creation, raw record writing, raw bytes reading, and full verbatim copy workflow Differential Revision: D96476344
Contributor
|
@danielyan86129 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96476344. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
without predefined DataLayout definitions
numeric RecordableTypeId
as raw bytes via processRecordHeader, skipping content block parsing
set_compression, get_stream_id) and Reader (set_raw_bytes_mode,
get_raw_bytes_mode)
has_raw_record_bytes properties
stream creation, raw record writing, raw bytes reading, and full
verbatim copy workflow
Differential Revision: D96476344