Enable AsyncImageFilter and FilteredFileReader bindings in OSS builds#363
Open
danielyan86129 wants to merge 3 commits intomainfrom
Open
Enable AsyncImageFilter and FilteredFileReader bindings in OSS builds#363danielyan86129 wants to merge 3 commits intomainfrom
danielyan86129 wants to merge 3 commits intomainfrom
Conversation
Summary: Update build-and-test and deploy GitHub Actions workflows for pyvrs2. Reviewed By: YLouWashU Differential Revision: D95732614
Summary: Add AriaGen2ImageDataLayout C++ bindings for pyvrs, enabling Python access to Aria Gen2 image data layout fields. Reviewed By: kongchen1992 Differential Revision: D96868595
Summary: - Enable AsyncImageFilter and FilteredFileReader pybind11 bindings in OSS builds by adding vrs_bindings/filter/*.cpp to OSS_VRSBINDINGS_SRC glob and filter/*.h to OSS_VRSBINDINGS_HEADERS glob - Move pybind_filter() and pybind_filtered_filereader() calls outside IS_VRS_FB_INTERNAL() preprocessor guards so they are registered in both OSS and internal builds - Add //arvr/libraries/vrs/utils:utils dep to vrsbindings_oss target (provides AsyncImageFilter C++ implementation) - Add missing PyUtils.h include in PyImageFilter.cpp (provides pyWrap) - Export AsyncImageFilter, AsyncImageFilterIterator, FilteredFileReader, and ImageRecordInfo from the OSS pyvrs __init__.py Differential Revision: D97196349
Contributor
|
@danielyan86129 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97196349. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
OSS builds by adding vrs_bindings/filter/.cpp to OSS_VRSBINDINGS_SRC
glob and filter/.h to OSS_VRSBINDINGS_HEADERS glob
IS_VRS_FB_INTERNAL() preprocessor guards so they are registered in
both OSS and internal builds
(provides AsyncImageFilter C++ implementation)
and ImageRecordInfo from the OSS pyvrs init.py
Differential Revision: D97196349