Fix macOS CI: set deployment target to 14.0, drop x86_64#368
Closed
danielyan86129 wants to merge 1 commit intomainfrom
Closed
Fix macOS CI: set deployment target to 14.0, drop x86_64#368danielyan86129 wants to merge 1 commit intomainfrom
danielyan86129 wants to merge 1 commit intomainfrom
Conversation
Summary: The pyvrs GitHub Actions CI started failing on macOS because cibuildwheel defaults MACOSX_DEPLOYMENT_TARGET to 10.9 for x86_64 builds, but VRS uses std::filesystem::path which requires macOS 10.15+. The error: `'path' is unavailable: introduced in macOS 10.15`. - Set MACOSX_DEPLOYMENT_TARGET=14.0 via CIBW_ENVIRONMENT_MACOS in both build-and-test.yml and deploy.yml - Drop x86_64 from CIBW_ARCHS_MACOS in deploy.yml (build-and-test.yml already only builds arm64) since Apple has ended x86_64 Mac support Differential Revision: D98636054
Contributor
|
@danielyan86129 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98636054. |
Contributor
|
This pull request has been merged in e8dbbc4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The pyvrs GitHub Actions CI started failing on macOS because
cibuildwheel defaults MACOSX_DEPLOYMENT_TARGET to 10.9 for x86_64
builds, but VRS uses std::filesystem::path which requires macOS 10.15+.
The error:
'path' is unavailable: introduced in macOS 10.15.build-and-test.yml and deploy.yml
already only builds arm64) since Apple has ended x86_64 Mac support
Differential Revision: D98636054