Skip to content

feat: show bluetooth connected devices - #32

Merged
faervan merged 10 commits into
faervan:mainfrom
yanganto:list-bt-devices
Nov 9, 2025
Merged

feat: show bluetooth connected devices#32
faervan merged 10 commits into
faervan:mainfrom
yanganto:list-bt-devices

Conversation

@yanganto

@yanganto yanganto commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Show connected bluetooth devices.

  • If only one bluetooth device, it will show icon with device name.
  • If more than one bluetooth devices, it will only show icons for these devices.
  • If no connected devices, then use bold/normal bluetooth font to show the power on/off status of bluetooth.

@yanganto
yanganto marked this pull request as draft November 5, 2025 16:14
@faervan

faervan commented Nov 5, 2025

Copy link
Copy Markdown
Owner

That looks awesome! Is there a reason for why Device and Controllor are public?

@yanganto
yanganto marked this pull request as ready for review November 6, 2025 00:50
Comment thread src/modules/bluetooth.rs Outdated
Comment thread src/modules/bluetooth.rs Outdated
Comment thread src/modules/bluetooth.rs
Comment thread src/modules/bluetooth.rs Outdated
@faervan

faervan commented Nov 6, 2025

Copy link
Copy Markdown
Owner

Mostly minor things, partially because I wanted to test how reviewing works on github 😆
The only thing that I really want to get changed is the font of the device name, that really stands out

@faervan faervan added the enhancement New feature or request label Nov 6, 2025
@yanganto

yanganto commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Bar-rs is daily used in my end, and I like this project.
If it is good, I will put the bluetooth setting feature on it, but it may take a longer time,

@yanganto
yanganto requested a review from faervan November 7, 2025 03:04
Comment thread src/modules/bluetooth.rs Outdated
@yanganto
yanganto requested a review from faervan November 9, 2025 11:11

@faervan faervan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thanks a lot for this PR :)

@faervan
faervan merged commit 691a59f into faervan:main Nov 9, 2025
8 checks passed
@yanganto

yanganto commented Nov 9, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for your project, it is simple, awesome, good for daily use.

@yanganto
yanganto deleted the list-bt-devices branch November 9, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants