Bitwise and, or, xor, and not operators#62
Open
muytingc wants to merge 3 commits intofaheel:masterfrom
Open
Conversation
…Have no implemented converting BigInt to two's complement binary numbers currently, but will be necessary in future versions
…ension of two's complement binary numbers, and two's complement binary numbers back to BigInt type
richardboehme
added a commit
to natalie-lang/natalie
that referenced
this pull request
Jan 11, 2022
Most of this was taken from the following PR in the BigInt repository: faheel/BigInt#62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excited to submit my first pull request for the repository. I know harish-vnkt already submitted a pull request for bitwise left and right shifts, but I added the other primary operators suggested in #60 with support for both positive and negative values using two's complement binary numbers.
I did my best to follow the other commenting and style conventions from the rest of the project, but I believe there could be some improvements, so I'd love suggestions. I did some basic testing on my own machine, but believe it could use more thorough testing especially in terms of efficiency.