Skip to content

Resolve Issue #1 : 📌 Feedback Kode & Raport Scoring 🚀 Habitly – Habit Tracker App #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roiskhoiron wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Resolve Issue #1 : 📌 Feedback Kode & Raport Scoring 🚀 Habitly – Habit Tracker App #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
056f38c
docs: adjust assessment scores and embed inline review comments
roiskhoiron Feb 24, 2026
5030517
docs: stop tracking assessment report markdown
roiskhoiron Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,5 @@ app.*.map.json
/android/app/debug
/android/app/profile
/android/app/release

ASSEMENT_FINAL_REPORT.MD
1 change: 1 addition & 0 deletions lib/data/services/habit_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import 'package:intl/intl.dart';
/// Service untuk mengelola data Habit
///
/// Memisahkan logic load/save/filter dari UI layer.
//{Inline Review: Pastikan tidak terjadi dual source of truth bila app utama sudah memakai Hive repository.}
class HabitService {
/// Kunci penyimpanan untuk SharedPreferences
static const String _storageKey = 'my_habits';
Expand Down
2 changes: 2 additions & 0 deletions lib/pages/home_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ class _HomePageState extends ConsumerState<HomePage> {

/// Handle delete habit (konfirmasi sudah ditangani oleh widget)
void _handleDeleteHabit(Habit habit) {
//{Inline Review: Operasi delete async sebaiknya di-await untuk memastikan feedback UI sesuai hasil persistence.}
ref.read(habitProvider.notifier).deleteHabit(habit.id);
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(content: Text("Habit deleted"), duration: Duration(seconds: 2)),
Expand All @@ -340,6 +341,7 @@ class _HomePageState extends ConsumerState<HomePage> {
return AddHabitModal(
onHabitCreated: (newHabitData) {
final newHabit = Habit.fromJson(newHabitData);
//{Inline Review: Tambahkan await + error handling agar snackbar sukses tidak tampil prematur.}
ref.read(habitProvider.notifier).addHabit(newHabit);
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(content: Text('Habit Created & Saved!'), backgroundColor: Colors.green),
Expand Down
1 change: 1 addition & 0 deletions lib/providers/habit_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class HabitState {
bool? isLoading,
String? error,
}) {
//{Inline Review: Pertimbangkan mekanisme clearError eksplisit agar error lama tidak terbawa ke state berikutnya.}
return HabitState(
habits: habits ?? this.habits,
isLoading: isLoading ?? this.isLoading,
Expand Down