Skip to content

fix: clarify VS Code reload action#874

Closed
BartWaardenburg wants to merge 1 commit into
mainfrom
feat/issue-869-vscode-reload-icon
Closed

fix: clarify VS Code reload action#874
BartWaardenburg wants to merge 1 commit into
mainfrom
feat/issue-869-vscode-reload-icon

Conversation

@BartWaardenburg
Copy link
Copy Markdown
Collaborator

@BartWaardenburg BartWaardenburg commented Jun 2, 2026

Summary

  • Switches the VS Code sidebar title action from search to refresh after analysis results have loaded.
  • Keeps the initial run action as Fallow: Run Analysis with $(search), then shows hidden delegated Fallow: Reload Analysis with $(refresh) once fallow.hasAnalyzed is true.
  • Adds manifest and integration coverage for the new command/menu wiring.

Issue

Closes #869

Plan

  • Local plan: .plans/vscode-reload-icon.md

Verification

  • npm run lint:js
  • npm run fmt:js:check
  • cd editors/vscode && pnpm run lint
  • cd editors/vscode && pnpm run test
  • cd editors/vscode && pnpm run check:codegen
  • cargo check --workspace
  • cargo test --workspace --all-targets
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo fmt --all -- --check
  • cargo doc --workspace --no-deps --document-private-items
  • git diff --check
  • fallow audit --format json --quiet

Audit note: the complexity finding introduced by touching editors/vscode/src/extension.ts was fixed by simplifying the config-change callback. The remaining audit failure is unrelated to this diff: existing unused dependency findings in benchmark/reference package manifests (benchmarks/knip6/package.json, reference/knip/package.json, and related benchmark files).

@BartWaardenburg BartWaardenburg force-pushed the feat/issue-869-vscode-reload-icon branch from ff36551 to f3351e0 Compare June 2, 2026 19:47
@BartWaardenburg BartWaardenburg force-pushed the feat/issue-869-vscode-reload-icon branch from f3351e0 to 5641437 Compare June 2, 2026 20:08
@BartWaardenburg BartWaardenburg deleted the feat/issue-869-vscode-reload-icon branch June 2, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

style(vs-code): reload icon

1 participant