Complete Mahjong Soul helper v0.3.0 - #1
Draft
farfromexact wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ActionNewRound, draw, discard, meld, kan, riichi, and round-state handling without inventing hidden information.Why
The previous implementation mixed transport capture, protobuf parsing, replay, diagnostics, and UI concerns, relied on fixed-offset guesses for Unity payloads, and could merge state across an uncaptured round boundary. This made live state restoration fragile and the acceptance evidence difficult to trust.
Impact
The helper remains passive: realtime advice is off by default, no game actions are automated, and WebSocket messages are not mutated. Captures now provide stronger diagnostics and replay agreement, while discontinuous samples are rejected instead of producing impossible hands.
A manual Unity session reached the live 20/20 MVP gate and 15/15 preflight and verified JSON download. Its exported sample crossed a paused round boundary, so the strict real-page gate correctly remains pending until a clean uninterrupted capture is collected.
Validation
npm run verifygit diff --check