Skip to content

Fix blank Settings window with menu bar redirect#20

Closed
mvanhorn wants to merge 1 commit into
farzaa:mainfrom
mvanhorn:fix/12-blank-settings-window
Closed

Fix blank Settings window with menu bar redirect#20
mvanhorn wants to merge 1 commit into
farzaa:mainfrom
mvanhorn:fix/12-blank-settings-window

Conversation

@mvanhorn
Copy link
Copy Markdown

@mvanhorn mvanhorn commented Apr 8, 2026

The Settings scene used EmptyView() to satisfy SwiftUI's one-scene requirement. But pressing Cmd+, still opens it, leaving users with a blank window (#12).

Replaced with a small view that says "Clicky lives in your menu bar" and points users to the menu bar icon. Uses system SF Symbol and standard secondary text colors.

Single file changed, 15 lines added. No new dependencies, no behavior changes outside the Settings window.

Fixes #12

This contribution was developed with AI assistance (Claude Code).

The Settings scene used EmptyView() which left users with a blank
window when pressing Cmd+,. Replace with a small view that explains
the app lives in the menu bar.

Fixes farzaa#12
@khaledmhirsi
Copy link
Copy Markdown

I could not push directly to this contributor branch (403 from GitHub), so I opened a fixed replacement PR here: #97.

The replacement keeps the original one-file fix, rebases it onto current main, and tightens the Settings message so users know to use the menu bar controls and that API keys are configured through the Worker setup rather than this blank Settings window.

Validated with:

  • swiftc -parse leanring-buddy/*.swift
  • npx --yes --package typescript tsc --noEmit --target ES2022 --module ESNext worker/src/index.ts
  • git diff --check origin/main...HEAD

@mvanhorn
Copy link
Copy Markdown
Author

Thanks @khaledmhirsi, #97 looks great. Closing this in favor of yours.

@mvanhorn mvanhorn closed this May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't open settings seeing an empty screen.

2 participants