Skip to content

Two definitions of conv imported in resnet.py #24

Description

@mnslarcher

In resnet.py there are (more than) two import *:

from .conv import *
from .init import *

Both contain a conv def. It took me a moment to figure out where the one that was actually used was (given the name I would have said in conv), maybe it would be helpful a refactoring or to avoid the "import *"? I think this is a classic case where import * can lead to unexpected behavior, what do you think?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions