fix(rpm): enforce usage of appBinaryName for assets and fix symlink logic #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic
- Refactored `AppPackageMakerRPM` to use `appBinaryName` (from CMake) instead of `appName` (from pubspec) when generating the `.spec` file, `.desktop` file, and copying icons. This ensures consistency with the `metainfo` file logic and prevents "File not found" errors when the binary name differs from the project name.
- Updated `MakeRPMConfig` to extend `MakeLinuxPackageConfig` to correctly detect the `BINARY_NAME`.
- Updated the `%install` section in the spec file to source all assets (`.desktop`, `.png`, `.xml`) using `$appBinaryName` and symlink the correct binary `$appBinaryName` to `%{name}` in `/usr/bin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
AppPackageMakerRPMto useappBinaryName(from CMake) instead ofappName(from pubspec) when generating the.specfile,.desktopfile, and copying icons. This ensures consistency with themetainfofile logic and prevents "File not found" errors when the binary name differs from the project name.MakeRPMConfigto extendMakeLinuxPackageConfigto correctly detect theBINARY_NAME.%installsection in the spec file to source all assets (.desktop,.png,.xml) using$appBinaryNameand symlink the correct binary$appBinaryNameto%{name}in/usr/bin.