Skip to content

test: cover falsy dynamic upstream fallback #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Sep 4, 2026
Merged

test: cover falsy dynamic upstream fallback #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions test/http-prefix-rewrite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,34 @@ test('reply.fromParameters cannot escape rewritePrefix', async t => {
t.assert.strictEqual(regular.statusCode, 200)
t.assert.strictEqual(regular.body, 'internal:/internal/foo')
})

test('HTTP request with a falsy dynamic upstream falls back to the default validation host', async t => {
const backend = Fastify()
const frontend = Fastify()

t.after(async () => {
await frontend.close()
await backend.close()
})

backend.get('/internal/*', request => `internal:${request.url}`)
await backend.listen({ port: 0, host: '127.0.0.1' })

frontend.register(proxy, {
upstream: '',
prefix: '/pub',
rewritePrefix: '/internal',
replyOptions: {
// Keep upstream falsy after getUpstream()
getUpstream () {
return ''
}
}
})
await frontend.listen({ port: 0, host: '127.0.0.1' })

const port = frontend.server.address().port
const response = await request(port, '/pub/foo')

t.assert.strictEqual(response.statusCode, 500)
})
Loading