Merged
Conversation
Member
|
can you fix the conflicts? |
Contributor
Author
|
@mcollina The branch is rebased. Please have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct
The context on why
tsdshould be replaced: fastify/fastify#6033.I think in this case it can be simply removed without introducing another type testing library.
expectType(), but thetsdcommand is not running.expectType()acts the same asexpectAssignable(), because it is only checked bytscand both assertions have the same type definitions (reference, reference).tscin the next line under the assertion.build:testscript makes sure all test files are type-checked; this can be verified by adding a failing line and runningnpm run build:test.Or do I miss something?