Skip to content

chore: remove tsd#1387

Merged
mcollina merged 2 commits intofastify:mainfrom
mrazauskas:remove-tsd
Apr 7, 2026
Merged

chore: remove tsd#1387
mcollina merged 2 commits intofastify:mainfrom
mrazauskas:remove-tsd

Conversation

@mrazauskas
Copy link
Copy Markdown
Contributor

Checklist


The context on why tsd should be replaced: fastify/fastify#6033.

I think in this case it can be simply removed without introducing another type testing library.

  • There is only one expectType(), but the tsd command is not running.
  • This means that expectType() acts the same as expectAssignable(), because it is only checked by tsc and both assertions have the same type definitions (reference, reference).
  • Assignability is already checked by tsc in the next line under the assertion.
  • The build:test script makes sure all test files are type-checked; this can be verified by adding a failing line and running npm run build:test.

Or do I miss something?

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Copy Markdown
Member

mcollina commented Apr 3, 2026

can you fix the conflicts?

@mrazauskas
Copy link
Copy Markdown
Contributor Author

@mcollina The branch is rebased. Please have a look.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3b6d088 into fastify:main Apr 7, 2026
14 checks passed
@mrazauskas mrazauskas deleted the remove-tsd branch April 7, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants