[Range] Enable range analysis for a bunch of monotonic functions#133
Draft
iksnagreb wants to merge 10 commits intofastmachinelearning:feature/ra_eltwisefrom
Draft
[Range] Enable range analysis for a bunch of monotonic functions#133iksnagreb wants to merge 10 commits intofastmachinelearning:feature/ra_eltwisefrom
iksnagreb wants to merge 10 commits intofastmachinelearning:feature/ra_eltwisefrom
Conversation
Note: Also treats MultiThreshold as such a monotonic function, but this needs more testing. Maybe MultiThreshold needs some special case implementation more similar to the Quant operator?
Note: Does not cover the integer range analysis yet
Note: We should probably implement a specialized integer range calculation for Split, but for now this seems to work just fine and recovers the expected behavior from before the recent merge.
Note: Does not change the node execution behavior as this is already covered by the assumptions of the multithreshold function, i.e., channels are axis 1.
Note: Only adds this to calc_intrange_eltwise_monotonic_intrangefirst for now, which is only used for Split. The "scalebiasfirst" variant could be extended in a similar way, but there is a warning in case of multiple outputs - probably for some reason.
Collaborator
Author
|
Keeping this as a draft for now, but we should probably never merge this and rather recreate or cherry-pick some of the commits for the eventual SIRA up-streaming @maltanar (we might have actually already done this on one of the SIRA branches...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Also treats MultiThreshold as such a monotonic function, but this needs more testing. Maybe MultiThreshold needs some special case implementation more similar to the Quant operator?