Skip to content

fix: apply clippy fixes#4687

Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1774051420-clippy-fixes
Closed

fix: apply clippy fixes#4687
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/1774051420-clippy-fixes

Conversation

@devin-ai-integration
Copy link
Contributor

Summary

Ran cargo clippy --fix and verified no remaining clippy warnings in project code. Changes across 6 files:

  • Cargo.toml: Exclude plugins/cli2 from workspace — the directory exists but its Cargo.toml was removed in a prior commit, breaking the plugins/* glob
  • posthog.rs: Remove redundant &distinct_id.to_string() when distinct_id is already &str
  • from_ast.rs, two fs-db migrations, version/macro.rs: Collapse nested if/if let blocks into let-chains (clippy collapsible_if / collapsible_match)
  • Two fs-db migrations: Remove unnecessary explicit lifetime 'a on group_by_session_id (lifetime elision suffices)

Review & Testing Checklist for Human

  • Verify the let-chain rewrites in from_ast.rs and version/macro.rs preserve the original control flow — especially that the fallthrough to result.push(c) in unescape_markdown still fires correctly when c == '\\' but the character is not escapable
  • Confirm the project's Rust edition / toolchain supports let-chains (stabilized in Rust 1.87+; project pins 1.92.0)
  • plugins/cli2 exclusion is correct — the directory only contains node_modules with no Cargo.toml

Notes

  • External crate libspa fails to build on Linux due to a version mismatch with the system libpipewire-0.3. This blocks clippy from checking the tools crate. This is a pre-existing issue unrelated to this PR.
  • macOS-only crates (objc2_app_kit, etc.) also can't be checked on Linux. All other workspace crates were checked with zero clippy warnings.

Link to Devin session: https://app.devin.ai/sessions/0c461d1399df4743963df3efc478e350

- Remove unnecessary &distinct_id.to_string() conversion in posthog.rs
- Collapse nested if-let chains into let-chains in tiptap, fs-db migrations
- Remove unnecessary lifetime annotations in group_by_session_id
- Exclude plugins/cli2 from workspace (missing Cargo.toml)

Co-Authored-By: bot_apk <apk@cognition.ai>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Mar 21, 2026

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit e6e18e1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69bde2ebd60d9a00082cf3d3
😎 Deploy Preview https://deploy-preview-4687--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 21, 2026

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit e6e18e1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69bde2eb4b99310008dd7891
😎 Deploy Preview https://deploy-preview-4687--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ComputelessComputer
Copy link
Collaborator

Closing cargo clippy PR - no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant