Open
Conversation
- Exclude plugins/apple-contact and plugins/pdf from workspace (missing Cargo.toml) - Simplify boolean expression in transcript speakers.rs (nonminimal_bool) - Remove unnecessary lifetime annotations (clippy auto-fix) - Collapse nested if-let chains into let-chains (clippy auto-fix) - Remove redundant closures (clippy auto-fix) Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
cargo clippy --fixand manually applied remaining suggestions. Changes across 6 files:plugins/apple-contactandplugins/pdffrom workspace — these directories exist but have noCargo.toml(onlynode_modules), breaking theplugins/*globnonminimal_bool):!word.is_final && !(a && b)→!(word.is_final || a && b)via De Morgan's lawif/if letblocks into let-chains (collapsible_if)needless_lifetimes)Followed up with
dprint fmtto satisfy thefmtCI check.Review & Testing Checklist for Human
speakers.rs:132is logically equivalent —!x && !(a && b)should equal!(x || a && b)by De Morgan's law, relying on&&binding tighter than||speakers.rs(lines 121-140) preserve the original control flow, especially the fallthrough paths when conditions are falseremember_identity(speakers.rs:166-170), the collapsed&& let Some(human_id) = identity.human_id.clone()is guarded byidentity.human_id.is_some()— confirm this is always redundant and safe to flattenplugins/apple-contactandplugins/pdfgenuinely have no Rust code that should be compiled (they only containnode_modules/)Notes
check (ubuntu/windows/macos),desktop_ci (linux-*), and downstreamciare pre-existingclicrate build errors (could not find 'process' in 'tokio') unrelated to this PR. Thefmtcheck passes, anddesktop_ci (macos)passes.libspahas a version mismatch with the systemlibpipewire-0.3, and macOS-only crates (objc2_app_kit, etc.) can't compile. This means thetoolscrate and macOS-specific crates were not linted. All other workspace crates were checked with zero remaining clippy warnings.Link to Devin session: https://app.devin.ai/sessions/0c461d1399df4743963df3efc478e350