Conversation
aisayo
requested review from
ashwinisukale and
kindoflew
and removed request for
a team
|
hi @arielj! can you review this when you have a minute (since you've done this kind of thing before)? thanks! |
|
@arielj ping |
| t.date "date" | ||
| t.datetime "created_at", null: false | ||
| t.datetime "updated_at", null: false | ||
| # These are extensions that must be enabled in order to support this database |
There was a problem hiding this comment.
I think we shouldn't include these change, they are unrelated to the review apps stuff
| @@ -1,329 +0,0 @@ | |||
| GEM | |||
There was a problem hiding this comment.
we shouldn't delete this file
| i18n (>= 0.7, < 2) | ||
| minitest (~> 5.1) | ||
| tzinfo (~> 1.1) | ||
| addressable (2.8.0) |
There was a problem hiding this comment.
we shouldn't update all this dependencies if they are not needed for the review apps, maybe they can be in another PR
|
when I try this I get an error in the github action: were the heroku keys configured in the repository secrets? one concern I have is: can users other than us add labels to PRs? not sure if there's a way to limit that to prevent unwanted users to trigger review apps |
|
@aisayo -- i know it's basically end of year, but just pinging to remind you that this has been reviewed by Ariel and you have some requested changes. thanks!! |
|
@aisayo Hi there, did you get a chance to review the comments in this PR? |
6 participants
The goal of this PR is to set up review apps for Pecas allowing us to add and remove the review label
I will abide by the code of conduct