Add Windows build support - #1
Merged
Merged
Conversation
- Switch build job runner from ubuntu-latest to windows-latest so the net8.0-windows TFM (needed for Prowlarr.Windows.dll) can be compiled - Uncomment win-x64/win-x86 PackageTests and Package calls in build.sh - Fix pre-existing typo: workflow set MINORVERSIONVERSION instead of PROWLARRVERSION, so UpdateVersionNumber in build.sh was silently a no-op and built binaries never got a real version stamped - Add MAJORVERSION/MINORVERSION env vars and --installer flag so Inno Setup can build a proper .exe installer via prowlarr.iss - Publish win-x64 test artifact, build_windows, and build_windows_installer artifacts from the build job - Release job downloads Windows build + installer artifacts, zips the raw build, and attaches zips + installer exe to the GitHub release - Remove lock.yml (runs daily, no purpose on a personal fork, just generates failure emails when GITHUB_TOKEN lacks lock permissions) Linux tarballs and Docker image are unaffected; .NET 8 cross-compiles all Linux RIDs from the Windows runner identically to before. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Windows build support (matching the Radarr fork fix), including a proper
.exeinstaller.ubuntu-latesttowindows-latest(required for thenet8.0-windowsTFM /Prowlarr.Windows.dll)build.shMINORVERSIONVERSIONinstead ofPROWLARRVERSION, so version stamping was silently broken--installerflag,MAJORVERSION/MINORVERSIONenv vars)lock.yml(daily cron, generates failure emails, no use on a personal fork)No impact on Linux/Docker users
.NET 8 cross-compiles all Linux RIDs from the Windows runner identically to before.
Generated with Claude Code