feat(sessions): show sub-task indicator for agent-delegated sessions#685
feat(sessions): show sub-task indicator for agent-delegated sessions#685helloworld89 wants to merge 1 commit into
Conversation
- Add parent_session_id to session-cache SQL query and CachedSession type - Add parentId to SearchResult interface and all search queries - Display orange 'sub-task' tag in Sessions list when session.parentId exists - Update remote-sessions.ts, ssh-remote.ts, and preload types for compatibility
Greptile SummaryThis PR propagates a
Confidence Score: 3/5The data-pipeline changes are solid, but the UI feature this PR introduces — an orange visual badge for agent sub-tasks — will render as an invisible/unstyled tag because the CSS rule for the new modifier class was never added. The entire user-visible goal of this PR is the styled sub-task badge, and that badge will appear with no distinguishing colour or weight because src/renderer/src/screens/Sessions/Sessions.tsx and src/renderer/src/assets/main.css — the badge class is used in JSX but the companion CSS rule is absent entirely. Important Files Changed
|
| <span className="sessions-tag sessions-tag--child" title="Agent sub-task"> | ||
| sub-task | ||
| </span> |
There was a problem hiding this comment.
Missing CSS modifier — badge will be unstyled
The class sessions-tag--child is applied to the sub-task badge, but no corresponding CSS rule exists in src/renderer/src/assets/main.css (only sessions-tag--source and sessions-tag--model are defined there). The PR description promises an "orange" badge, but at runtime the span will fall back entirely to the base .sessions-tag styles, rendering identically to any other tag with no visual differentiation. A rule like .sessions-tag--child { color: orange; font-weight: 500; } (or a CSS variable equivalent) needs to be added to main.css.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Adds a visual indicator on the Sessions page to distinguish sessions created by agent delegation (sub-tasks) from manually created sessions.
Changes
parent_session_idto the SQL query andparentIdto theCachedSessioninterfaceparentIdtoSearchResultand all session search queriessub-tasktag next to session cards whensession.parentIdis setparentIdfor compatibilityScreenshots
(Add screenshots after visual verification)
Testing
npm run typecheck)npm run devand check Sessions page shows orangesub-taskbadge for delegated sessions