Add Anthropic Claude OAuth support and enhance Factory tab features

[Avi-Bendetsky]

No description provided.

[greptile-apps]

Greptile Summary

This PR adds Anthropic Claude OAuth (native PKCE paste-a-code flow), a multi-profile session aggregator with desktop-owned pin/status/group metadata, a Factory governance tab, and an LLM Council configuration panel.

• Anthropic OAuth: A new PKCE flow in the main process (hermes-auth.ts) builds the authorize URL, exchanges the pasted code for tokens, and persists them into the engine credential pool via a Python one-liner — with two issues noted (token exposure via argv and a loose success-check substring match).
• Multi-profile sessions: sessions.ts gains aggregated listing/search/delete/rename across every profile's state.db, with lazily-created desktop-owned tables for pin, status, and group metadata.
• Factory & Council: New kanban govern wrappers and a council-config.ts JSON store power two new UI tabs, each backed by fresh IPC handlers in index.ts.

Confidence Score: 3/5

Safe to merge for most users, but the Anthropic OAuth token persistence passes live credentials through the process argv, which is readable by other same-user processes on the machine.

The multi-profile session aggregator and Factory/Council UI additions are well-structured. The Anthropic PKCE flow is the concerning path: access_token and refresh_token are handed to Python as positional sys.argv arguments, making them briefly visible in the OS process table to any process running under the same UID. The success detection also uses a substring check that could silently report success on a failed token-persistence run. These issues live on a high-value path (OAuth credential storage) and warrant a fix before the feature ships widely.

src/main/hermes-auth.ts — the persistAnthropicToken function and its subprocess invocation deserve the most attention.

Security Review

• Credential exposure via process table (src/main/hermes-auth.ts ~line 318): accessToken and refreshToken are passed as positional CLI arguments to the Python subprocess. On Linux, /proc/<pid>/cmdline exposes them to any same-UID process for the subprocess's lifetime; on macOS they appear in ps aux output. Tokens should be delivered via stdin or an environment variable instead.

Important Files Changed

Filename	Overview
src/main/hermes-auth.ts	Adds Anthropic PKCE OAuth flow natively in the main process; tokens are passed as CLI argv to the Python persistence script (process table exposure), and the success check uses a substring match that could misfire on error messages.
src/main/sessions.ts	Adds multi-profile session aggregation with desktop-owned metadata tables (pin, status, groups); the openProfileDb readonly parameter is a dead ternary but intentionally always opens writable. Logic is otherwise sound.
src/main/index.ts	Wires up ~100 new IPC handlers for Anthropic OAuth, Council config, multi-profile sessions, and Factory governance; the pendingAnthropic state is scoped correctly and the Anthropic flow lacks an activeProc-style guard but this is not dangerous given Node's event-loop serialisation.
src/renderer/src/components/OAuthLoginModal.tsx	Extended to handle the Anthropic paste-a-code PKCE path alongside the existing CLI-loopback flow; StrictMode double-invoke guard is in place and the success/cancel paths are correct.
src/main/kanban.ts	Adds four Factory governance functions (governStatus, governSet, governKillSwitch, governModels) that delegate to hermes kanban govern; clean and consistent with existing kanban helpers.
src/main/council-config.ts	New per-profile JSON-backed Council config store; well-structured with safe defaults and no cross-profile leakage.
src/renderer/src/screens/Factory/Factory.tsx	New Factory governance UI with auto-refresh, toast notifications, and activity filters; no logic issues observed.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant UI as OAuthLoginModal (Renderer)
    participant IPC as Electron IPC (Main)
    participant Auth as hermes-auth.ts
    participant Anthropic as Anthropic OAuth
    participant Python as Python subprocess

    UI->>IPC: anthropic-oauth-start
    IPC->>Auth: buildAnthropicAuthUrl()
    Auth-->>IPC: "{ url, verifier, state }"
    IPC-->>UI: "{ url }"
    UI->>Anthropic: open browser → user authorizes
    Anthropic-->>UI: "user pastes code#state"
    UI->>IPC: anthropic-oauth-submit(code, profile)
    IPC->>Auth: exchangeAnthropicCode(code, verifier, state)
    Auth->>Anthropic: POST /v1/oauth/token (PKCE)
    Anthropic-->>Auth: "{ access_token, refresh_token, expires_in }"
    Auth->>Python: execFile(python, ["-c", script, access_token, refresh_token, expires_in])
    Note over Python: tokens visible in process table
    Python-->>Auth: stdout OK label
    Auth-->>IPC: "{ success: true, persisted: true }"
    IPC-->>UI: success → onSuccess()

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant UI as OAuthLoginModal (Renderer)
    participant IPC as Electron IPC (Main)
    participant Auth as hermes-auth.ts
    participant Anthropic as Anthropic OAuth
    participant Python as Python subprocess

    UI->>IPC: anthropic-oauth-start
    IPC->>Auth: buildAnthropicAuthUrl()
    Auth-->>IPC: "{ url, verifier, state }"
    IPC-->>UI: "{ url }"
    UI->>Anthropic: open browser → user authorizes
    Anthropic-->>UI: "user pastes code#state"
    UI->>IPC: anthropic-oauth-submit(code, profile)
    IPC->>Auth: exchangeAnthropicCode(code, verifier, state)
    Auth->>Anthropic: POST /v1/oauth/token (PKCE)
    Anthropic-->>Auth: "{ access_token, refresh_token, expires_in }"
    Auth->>Python: execFile(python, ["-c", script, access_token, refresh_token, expires_in])
    Note over Python: tokens visible in process table
    Python-->>Auth: stdout OK label
    Auth-->>IPC: "{ success: true, persisted: true }"
    IPC-->>UI: success → onSuccess()

Loading

_{Reviews (1): Last reviewed commit: "feat(council): LLM Council — composer co..." | Re-trigger Greptile}

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[greptile-apps]

Too many files changed for review. (287 files found, 100 file limit)