Add refund_standalone function with tests#31
Open
chen-gloria wants to merge 2 commits intofatzebra:mainfrom
Open
Add refund_standalone function with tests#31chen-gloria wants to merge 2 commits intofatzebra:mainfrom
chen-gloria wants to merge 2 commits intofatzebra:mainfrom
Conversation
- Implements standalone refund functionality without requiring original transaction ID - Supports refunding to a card token directly - Includes comprehensive validation for all parameters - Adds 3 test cases covering valid refunds, invalid tokens, and extra parameters - Follows existing code patterns and documentation standards
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Author
|
Hi @amasses, I've submitted this PR to add standalone refund functionality to the PHP library. All tests are passing (3/3), and the implementation follows existing code patterns. Looking forward to your feedback! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Implements a new standalone refund functionality for the FatZebra PHP Gateway library that allows merchants to process refunds directly to a card token without requiring an original transaction ID.
Jira ticket: N/A
Details of change
refund_standalone($amount, $reference, $card_token, $extra = null)method in the Gateway classChange Rollback Plan
refund_standalone()method fromsrc/Gateway.php(lines 366-395)test/GatewayTest.php(test_refund_standalone, test_refund_standalone_invalid_token, test_refund_standalone_with_extra)composer.jsonandcomposer.lockto remove PHPUnit dev dependency🧨 Risk assessment
Name: New method behavior or API incompatibility
Severity: Minor
Likelihood: Unlikely
Impact: 🟢 Low
Severity justification:
refund()method patternLikelihood justification:
Risk mitigation:
Change Checklist
The following must be reviewed and signed off by the creator of the PR. To sign off review and check each
🔑 Security
Testing of Changes
🔎 Quality assurance