Skip to content

Fix: entries removed from Groups window not re-created on reimport #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
takararei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: entries removed from Groups window not re-created on reimport #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Editor/AddressableImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,11 @@ static AddressableAssetEntry CreateOrUpdateAddressableAssetEntry(
// CreateOrMoveEntry is very slow, so don't move anything if the group is already the correct one
var guid = AssetDatabase.AssetPathToGUID(assetPath);
var entry = settings.FindAssetEntry(guid);
if (entry == null || entry.parentGroup != group)
// When manually removing an entry from the Addressables Groups window,
// it may remain in settings' GUID→Entry map but be removed from the group's entries list
// (a "zombie entry"). Check that the entry is actually present in the group before skipping CreateOrMoveEntry.
var isInGroup = entry != null && entry.parentGroup != null && entry.parentGroup.entries.Contains(entry);
if (entry == null || entry.parentGroup != group || !isInGroup)
entry = settings.CreateOrMoveEntry(guid, group);

if (entry != null)
Expand Down