Repository navigation
'ratio_disc' validation - #48
Merged
fbargaglistoffi merged 2 commits intoOct 13, 2026
Merged
fbargaglistoffi merged 2 commits into
fbargaglistoffi merged 2 commits into
Conversation
Owner
|
Thanks, Charlie! I reviewed the changes, and everything looks good. I also added drop = FALSE when constructing A_est to preserve the matrix dimensions. The updated validation addresses Reviewer 1, Comment 2.3, including the boundary cases arising from rounding. The R CMD check also passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds validation to ensure that 'ratio_disc' leaves at least one cluster in both the discovery and estimation samples. Moreover, it rejects invalid boundary values.