Allow setting the collectors through the config file#21
Open
fbegyn wants to merge 2 commits into
Open
Conversation
This makes the maintenance of exporters a little bit easier and allows for lightwight builds of the exporter by filtering out collectors at built time( should look into it),. Assisted-by: Claude code opus 4.7 Signed-off-by: Francis Begyn <francis@begyn.be>
Assisted-by: Claude code opus 4.7 Signed-off-by: Francis Begyn <francis@begyn.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required some reworking of the collector code to make this work a bit more elegantly.
The old collector config code was thrown together quite rapidly and wasn't easy to maintain or work on (I had to change ode in 3 places when working on the collectors). Node exporter has quite an elegant way for collectors I've always found, so the code base has been changed in line with that behavior.
Before being able to merge it, I need to validate the built and runtime behavior and also clean up the documentation a bit.