fix: Make pytest config compatible with newer pytest #5779
Conversation
ntkathole
changed the title
ntkathole
force-pushed
the
fix/pytest-windows-test-config
branch
from
e5ef90b to
99c742d
Compare
|
@antznette1 Can you please fix the linting ? Thanks |
antznette1
force-pushed
the
fix/pytest-windows-test-config
branch
from
081c356 to
1835d0f
Compare
I have done it. |
|
@antznette1 looks like you need to resolve conflicts please. |
|
@copilot can you help resolve the conflicts and remove the commits not related to this branch? |
Good day Sir, |
|
@antznette1 there are quite a number of conflicts that need to be resolved 😅 |
Signed-off-by: amiraifori <iforiamira@gmail.com> Signed-off-by: antznette1 <ochiezeanthonette@gmail.com> Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
antznette1
force-pushed
the
fix/pytest-windows-test-config
branch
from
1835d0f to
11f0ff0
Compare
I have worked on the conflicts; it's not conflicted anymore |
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com> Signed-off-by: antznette1 <Ochiezeanthonette@gmail.com>
antznette1
force-pushed
the
fix/pytest-windows-test-config
branch
from
11f0ff0 to
2abd8be
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| We also utilize indirect parametrization here. Since [environment](cci:1://file:///c:/Users/brass/OneDrive/Desktop/Work/App/Lanre/feast/sdk/python/tests/conftest.py:229:0-245:16) is a fixture, | ||
| when we call metafunc.parametrize("environment", ..., indirect=True) we actually | ||
| parametrizing this "environment" fixture and not the test itself. | ||
| Moreover, by utilizing `_config_cache` we are able to share `environment` fixture between different tests. | ||
| Moreover, by utilizing `_config_cache` we are able to share [environment](cci:1://file:///c:/Users/brass/OneDrive/Desktop/Work/App/Lanre/feast/sdk/python/tests/conftest.py:229:0-245:16) fixture between different tests. |
There was a problem hiding this comment.
🟡 Docstring corrupted with IDE-generated link artifacts
The docstring in pytest_generate_tests has been corrupted with IDE-generated link artifacts that make the documentation confusing and hard to read.
Click to expand
What happened
The docstring was modified to include what appear to be IDE-generated links (possibly from Devin AI or another tool):
Before:
We also utilize indirect parametrization here. Since `environment` is a fixture,
...
Moreover, by utilizing `_config_cache` we are able to share `environment` fixture between different tests.After:
We also utilize indirect parametrization here. Since [environment](cci:1://file:///c:/Users/brass/OneDrive/Desktop/Work/App/Lanre/feast/sdk/python/tests/conftest.py:229:0-245:16) is a fixture,
...
Moreover, by utilizing `_config_cache` we are able to share [environment](cci:1://file:///c:/Users/brass/OneDrive/Desktop/Work/App/Lanre/feast/sdk/python/tests/conftest.py:229:0-245:16) fixture be... [truncated]These cci:1://file:///c:/Users/... links are not valid markdown or Python documentation, and the second line is also truncated with [truncated].
Impact
Documentation is corrupted and harder to read. No functional impact.
Recommendation: Restore the original docstring text by replacing the IDE-generated links with the original backtick-quoted environment references.
Was this helpful? React with 👍 or 👎 to provide feedback.
3 participants
What this PR does / why we need it:
_pytest.warning_types.*warning classes (breaks on newer pytest).sys.platformiswin32, notwindows).Why we need it:
Testing
forkstart method.