feat: Add integration tests for dbt import #5899

YassinNouh21 · 2026-01-24T11:46:01Z

Summary

Add comprehensive integration tests for dbt import functionality
Fix bugs in test assertions (entity.join_key, object count, entity comparison)
Add test coverage for error handling, type mapping edge cases, and code generation validation

Test Coverage

37 tests covering:
- Manifest parsing and filtering
- All data source types (BigQuery, Snowflake, File)
- Type mapping including Array, Bool, parameterized types
- Error handling (missing manifest, invalid JSON)
- Code generation with ast.parse() validation

Test plan

All 37 tests pass locally
Tests are isolated with pytest.ini to avoid loading heavy dependencies

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

…generate it Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Bug fixes: - Fix entity.join_keys -> entity.join_key (singular string attribute) - Fix object count assertion (12 -> 9) - Fix entity comparison to use .name (feature_view.entities returns strings) New test coverage: - Error handling: manifest not found, invalid JSON - Type mapping edge cases: Bool, Array, unknown types, parameterized types - Snowflake NUMBER with precision/scale handling - created_timestamp_column parameter - Custom timestamp field override - Generated code validation with ast.parse() Add pytest.ini for test isolation from parent conftest.py Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

- Remove 'dbt test' from workflow (dbt build already runs tests) - Remove unused pytest import from conftest.py - Tables are in-memory and disappear after dbt build completes Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

The -c flag expects a directory path, not a config file name. Since we're already in the feast_repo directory, feast will automatically find the feature_store.yaml file. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Update tests to be flexible with actual dbt output instead of hardcoded values: - Don't assert specific dbt_version - just verify it's present - Use model.database and model.schema dynamically (varies by adapter) - Verify full_table_name is built correctly from components - Fix unused parameter warning in test_create_entity Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Tags in dbt must be placed inside a config block to appear in the generated manifest.json. Without this, the tags were not being included when dbt build runs in CI. Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

- Remove trailing whitespace from blank lines - Add noqa: E402 comments for imports after pytest.importorskip Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Add pytest collection hook to automatically skip dbt tests when the manifest.json file hasn't been generated yet. This prevents failures in the unit-test-python workflow which doesn't run dbt build. The dbt-integration-test workflow generates the manifest before running tests, so tests will still execute there. Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

franciscojavierarceo · 2026-01-26T13:38:41Z

.github/workflows/dbt-integration-tests.yml

+          dbt deps
+          dbt build
+
+      - name: Setup Feast project for dbt import test


Nice! Can you instead put most of the logic into the Makefile so that we can easily run make dbt-integration-test and swap that here?

franciscojavierarceo · 2026-01-26T13:40:31Z

sdk/python/pytest.ini


 filterwarnings =
    error::_pytest.warning_types.PytestConfigWarning
-    error::_pytest.warning_types.PytestUnhandledCoroutineWarning


why remove this?

1. Move dbt integration test logic into Makefile - Add test-python-integration-dbt target to consolidate test steps - Makes it easy to run `make test-python-integration-dbt` locally - Simplifies GitHub Actions workflow 2. Restore pytest warning filter - Re-add error::_pytest.warning_types.PytestUnhandledCoroutineWarning - This was accidentally removed and should be kept Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

YassinNouh21

Addressed review comments in the latest commit:

Comment 1 (Makefile): Created test-python-integration-dbt target that consolidates all the dbt test logic. Now you can run make test-python-integration-dbt locally!

Comment 2 (pytest.ini): The error::_pytest.warning_types.PytestUnhandledCoroutineWarning line was accidentally removed. It's been restored.

franciscojavierarceo · 2026-01-26T13:49:00Z

@YassinNouh21 can you post a screen shot of the feast UI and the dbt UI lineage graphs to see how they render?

Also looks like you may have this hooked up to mcp to handle this, which is pretty cool

franciscojavierarceo · 2026-01-26T14:00:04Z

@YassinNouh21 you can spin up the UI locally with feast ui after you compile the dbt models. you should also be able to render the dbt ui locally.

YassinNouh21 · 2026-01-26T14:51:26Z

franciscojavierarceo · 2026-01-26T15:14:49Z

hmm the protobuf issue sounds like a real concern, no?

Copilot AI and others added 8 commits January 16, 2026 20:15

Initial plan

c3f2e0f

Add dbt integration tests and test dbt project

9bee2c7

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Add manifest.json and GitHub Actions workflow for dbt tests

8ba2205

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Add documentation and README files for dbt integration tests

3432eb5

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Use Makefile for dependency installation in dbt workflow

621cefb

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Simplify profiles.yml to only use DuckDB for testing

e25d08f

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Add dbt commands and Feast CLI integration testing with SQLite

ba38da0

Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

Fix test failures by removing pre-committed manifest and letting dbt …

586f825

…generate it Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>

YassinNouh21 requested a review from a team as a code owner January 24, 2026 11:46

YassinNouh21 added 3 commits January 24, 2026 13:53

Remove unnecessary README documentation files

7f023b1

Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

YassinNouh21 force-pushed the copilot/add-integration-tests-for-dbt-import branch from 4423c32 to 37224b0 Compare January 24, 2026 11:53

YassinNouh21 and others added 7 commits January 24, 2026 14:06

Fix feast CLI: remove incorrect -c flag

e45bcb6

The -c flag expects a directory path, not a config file name. Since we're already in the feast_repo directory, feast will automatically find the feature_store.yaml file. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Fix lint errors in dbt integration tests

cb09148

- Remove trailing whitespace from blank lines - Add noqa: E402 comments for imports after pytest.importorskip Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Apply ruff formatting to dbt integration tests

932c559

Signed-off-by: David Soria Parra <dsp@php.net> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>

Merge branch 'master' into copilot/add-integration-tests-for-dbt-import

3edce4f

franciscojavierarceo reviewed Jan 26, 2026

View reviewed changes

YassinNouh21 commented Jan 26, 2026

View reviewed changes

Merge branch 'master' into copilot/add-integration-tests-for-dbt-import

6954f13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add integration tests for dbt import #5899

feat: Add integration tests for dbt import #5899

Uh oh!

YassinNouh21 commented Jan 24, 2026

Uh oh!

franciscojavierarceo Jan 26, 2026

Uh oh!

franciscojavierarceo Jan 26, 2026

Uh oh!

YassinNouh21 left a comment

Uh oh!

franciscojavierarceo commented Jan 26, 2026

Uh oh!

franciscojavierarceo commented Jan 26, 2026

Uh oh!

YassinNouh21 commented Jan 26, 2026

Uh oh!

franciscojavierarceo commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: Add integration tests for dbt import #5899

Are you sure you want to change the base?

feat: Add integration tests for dbt import #5899

Uh oh!

Conversation

YassinNouh21 commented Jan 24, 2026

Summary

Test Coverage

Test plan

Uh oh!

franciscojavierarceo Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

YassinNouh21 left a comment

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo commented Jan 26, 2026

Uh oh!

franciscojavierarceo commented Jan 26, 2026

Uh oh!

YassinNouh21 commented Jan 26, 2026

Uh oh!

franciscojavierarceo commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants