Open
Conversation
- exporting IconProps so it can be available to TypeScript components using react-feather - as is it needs to duplicated, which is fragile because react-feather could change - renamed "Props" to "IconProps"
We want to be able to preview the icons in this package so a link is helpful!
Add React@^17 to peerDependencies
Add link to feather icons
Export IconProps typedef so projects can re-use
|
Any update on this? |
Author
|
@fdev i have created a fork with these changes in case it would help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #40, I think a better way to adapt the sizes would be to define by default with typographic measures, instead of pixels.
Changes