chore: 0.5.1 - #38
Merged
Merged
Conversation
Ships the fix for a bare `secretscreen` at an interactive terminal, which fell through to sys.stdin.read() and blocked forever — indistinguishable from a hang, and the first thing anyone types after installing (#37). Version only; the two places it is recorded have to agree with the tag.
featurecreep-cron
added
the
no-test-gate
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release bump so the #37 fix reaches PyPI — it has been sitting on
mainunreleased, since publishing is release-triggered.What 0.5.1 ships
#37 — a bare
secretscreenno longer blocks forever at a terminal. It fell through tosys.stdin.read(), which at an interactive TTY waits indefinitely: indistinguishable from a hang, and the first thing anyone types after installing. No FILE plus a TTY on stdin now prints the help and exits 2. An explicit-still reads the terminal, and pipes are unaffected.Also on
mainsince 0.5.0, neither user-facing: the Test Gate (#35) and a Dependabot actions bump.Version bump only
pyproject.tomlandsrc/secretscreen/__init__.pyboth record the version and must agree with the tag.no-test-gateapplied — there is no behaviour change to write a failing test against, which is exactly what that label is for. Note it did not exist until now:test-gate.ymlhas referenced it since #35, so the documented exemption was unusable. Created with the workflow's own wording.