Skip to content

Conversation

@rfultz
Copy link
Contributor

@rfultz rfultz commented May 28, 2025

Summary

Initial build for the FECfile+ eligibility widget

Required reviewers

  • UX
  • devs

Impacted areas of the application

General components of the application that this PR will affect:

  • Admin Fines calculator: specifically use Vue 2 and don't switch to 3. Yet.
  • Admin Fines: fixed typos
  • gulpfile: fixed a typo
  • init.js: edited to include a check for this widget's launch button
  • Webpack config: added this widget, added config vars for Vue 3, removed a previously-commented legal config (that wasn't being used)
  • package.json: added Vue 3 beside Vue 2

Screenshots

image

image

image

image

image

Related PRs

None

How to test

CMS

  • Go into the admin or pages (www team)
  • Edit a Wagtail page to include something like <button class="button button--cta button--go js-launch-fecfile-eligibility">Launch!</button> (The js-launch-fecfile-eligibility class is the important part)

(I used http://127.0.0.1:8000/help-candidates-and-committees/filing-reports/electronic-filing/getting-started-fecfile-pilot/ because it seemed to make sense)

Code

  • Pull the branch
  • npm i
  • npm run build
  • Go to the page (the H4CC page linked above)
  • Your button should appear but the should not be open
  • Click your new button
  • The <dialog> should open
  • Click the X to close it. (It should close)
  • Edit the URL to append ?dialog=open and hit Enter
  • The <dialog> should start in an open state
  • From this point, review all the content and functionality across device widths (>=400px)
  • Also: check that the admin fines calculator still works fine

@rfultz rfultz requested a review from JonellaCulmer May 28, 2025 16:58
@rfultz rfultz self-assigned this May 28, 2025
@rfultz rfultz moved this to 👀 Ready in Website project May 28, 2025
@rfultz rfultz changed the title [WIP] 6711 FECfile+ Eligibility Widget 6711 FECfile+ Eligibility Widget May 28, 2025
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.17%. Comparing base (e5a9723) to head (010cca5).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6793   +/-   ##
========================================
  Coverage    78.17%   78.17%           
========================================
  Files          240      240           
  Lines         5407     5407           
========================================
  Hits          4227     4227           
  Misses        1180     1180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfultz rfultz added this to the 28.5 milestone Jun 3, 2025
@JonellaCulmer JonellaCulmer modified the milestones: 28.5, 28.6 Jun 17, 2025
@rfultz rfultz modified the milestones: 28.6, 29.1 Jul 24, 2025
@patphongs patphongs modified the milestones: 29.1, 29.2 Aug 14, 2025
@JonellaCulmer JonellaCulmer modified the milestones: 29.2, 29.4 Aug 26, 2025
@pkfec pkfec modified the milestones: 29.4, 29.5 Sep 16, 2025
@JonellaCulmer
Copy link
Contributor

@rfultz Two changes from Ryan, both on the allocating question:

  1. Update the allocating question to: "Does your committee anticipate allocating financial activity between federal and nonfederal accounts and/or anticipate receiving bundled contributions from lobbyists/registrants and lobbyist/registrant PACs?"
  2. Remove the Example text below that question.
Screenshot 2025-09-24 at 11 28 03 AM

No other changes. Once that's done I can approve.

@rfultz
Copy link
Contributor Author

rfultz commented Sep 24, 2025

@JonellaCulmer
image

@rfultz rfultz requested a review from patphongs September 24, 2025 18:13
Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the last-minute changes on the allocating screen.

@kathycarothers kathycarothers modified the milestones: 29.5, 29.6 Sep 30, 2025
@patphongs patphongs modified the milestones: 29.6, 30.2 Nov 20, 2025
@rfultz rfultz modified the milestones: 30.2, 30.3 Dec 2, 2025
@patphongs patphongs modified the milestones: 30.3, 30.5 Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 Ready

Development

Successfully merging this pull request may close these issues.

Build efiling wizard to help guide potential users

6 participants