Skip to content

Conversation

@Elaine-Krauss-TCG
Copy link
Contributor

Ticket link: here

Related PRs:

Copy link
Contributor

@sasha-dresden sasha-dresden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! I definitely like having this in the database over the transaction_view. I know the ticket had mentioned removing the transaction_view altogether. Did we maybe want a follow up ticket to remove that? Or maybe there's still some lingering information in the transaction_view that we need.

@Elaine-Krauss-TCG
Copy link
Contributor Author

This looks amazing! I definitely like having this in the database over the transaction_view. I know the ticket had mentioned removing the transaction_view altogether. Did we maybe want a follow up ticket to remove that? Or maybe there's still some lingering information in the transaction_view that we need.

I talked with Todd briefly about this last week. Removing the transaction_view is definitely a goal, but not for this ticket. There's a few more annotated fields that we're leaning on, namely annotation that copy values from the schedule objects into a standardized format on the transaction object (e.g, "Amount" or "Date").

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@lbeaufort lbeaufort changed the title Feature/2003 Feature/2003 [Spike] Moving debt values out of annotations Dec 11, 2025
@lbeaufort lbeaufort changed the title Feature/2003 [Spike] Moving debt values out of annotations [Don't merge] Feature/2003 [Spike] Moving debt values out of annotations Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants