Bug Description
state_color gives colours to pending, running, completed, the four hard failures and cancelled, then sends everything else to a wildcard grey. That catch-all currently swallows OutOfMemory, Preempted and Suspended along with Unknown, so an out-of-memory kill renders exactly like a state sqwatch does not recognise. v0.1.1 added SUSPENDED and OUT_OF_MEMORY to the recognised states without giving them colours, so this is an unfinished change rather than a judgement call.
Steps to Reproduce
Have a job killed for exceeding its memory limit, then look at it in the table next to a FAILED row.
Expected Behavior
An OOM kill reads as a failure at a glance. Colour is the signal the table is built around, so a job that died should not look like a job whose state could not be parsed.
Actual Behavior
OUT_OF_MEMORY -> Rgb(180, 180, 180) # the wildcard
PREEMPTED -> Rgb(180, 180, 180)
SUSPENDED -> Rgb(180, 180, 180)
UNKNOWN -> Rgb(180, 180, 180)
OOM is the most common way an HPC job dies, and it scans as neutral grey beside red FAILED rows.
System Information
sqwatch 0.2.0, source checkout at 4c594fb
Four explicit arms in place of the wildcard covers it: OOM belongs with Failed, Preempted with Cancelled, and Suspended wants its own colour since the job is still holding its allocation. Dropping the wildcard is the part that matters, because it turns "someone forgot" into a compile error the next time a state is added, including the Completing variant that #16 needs.
A configurable palette and NO_COLOR are #35, not this.
Bug Description
state_colorgives colours to pending, running, completed, the four hard failures and cancelled, then sends everything else to a wildcard grey. That catch-all currently swallowsOutOfMemory,PreemptedandSuspendedalong withUnknown, so an out-of-memory kill renders exactly like a state sqwatch does not recognise. v0.1.1 added SUSPENDED and OUT_OF_MEMORY to the recognised states without giving them colours, so this is an unfinished change rather than a judgement call.Steps to Reproduce
Have a job killed for exceeding its memory limit, then look at it in the table next to a FAILED row.
Expected Behavior
An OOM kill reads as a failure at a glance. Colour is the signal the table is built around, so a job that died should not look like a job whose state could not be parsed.
Actual Behavior
OOM is the most common way an HPC job dies, and it scans as neutral grey beside red FAILED rows.
System Information
sqwatch 0.2.0, source checkout at 4c594fbFour explicit arms in place of the wildcard covers it: OOM belongs with Failed, Preempted with Cancelled, and Suspended wants its own colour since the job is still holding its allocation. Dropping the wildcard is the part that matters, because it turns "someone forgot" into a compile error the next time a state is added, including the
Completingvariant that #16 needs.A configurable palette and
NO_COLORare #35, not this.