Fetch the filter fields even when their column is hidden - #46
Open
fedonman wants to merge 1 commit into
Open
Conversation
rebuild_format built the squeue format string from the visible columns only, so hiding User or Name stopped %u or %j being requested. The two regex filters run client side against those values, which stayed empty, so the filter matched nothing and emptied the table while the flash bar reported it working. Force the codes the same way %Z is already forced for the custom widgets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
squeue --formatstring was built from the visible columns alone, so hiding the User or Name column stopped%uor%jbeing requested at all. Both filters run client side against those values, which then stayed empty, and the table emptied while the flash bar said the filter had worked. The two codes are now forced into the format string when their filter is set, the same way%Zis already forced when a custom widget needs the working directory. The assembly moved into aformat_codeshelper so it can be tested, and five tests cover it, including a decode of squeue output through a format string with the User column hidden.Closes #10