Keep scontrol values that contain a space - #47
Open
fedonman wants to merge 1 commit into
Open
Conversation
parse_scontrol_kv split on whitespace and then cut each token at its first =, so any value with a space in it stopped at that space. All four values sqwatch keeps are user-controlled paths, so a scratch directory with a space in its name gave the wrong path and the log pane waited on a file that was never going to appear. Find the keys with a regex and take each value up to the start of the next one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_scontrol_kvsplit the output on whitespace and cut each token at its first=, so a value with a space in it stopped at the space. The four values sqwatch keeps fromscontrolare all user-controlled paths, so a working directory like/scratch/Smith Labcame back as/scratch/Smithand the log pane sat waiting on a path that does not exist. Keys are now found with a regex and each value runs to the start of the next key. Seven tests cover it, including the ordinary output that has no spaces in it.Closes #11