Report sinfo and sacctmgr failures instead of an empty cluster - #48
Open
fedonman wants to merge 1 commit into
Open
Report sinfo and sacctmgr failures instead of an empty cluster#48fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
list_partitions and list_nodes only checked that sinfo could be spawned, so a non-zero exit gave an empty list that looked like a small cluster, and check_slurm_available returned Ok whatever squeue exited with. list_qos did check the status but still returned an empty Vec, so the caller could not tell a cluster with no accounting database from a sacctmgr that failed. The three list calls now return a Result carrying whatever the command printed, startup stops on a failing squeue, and a failed probe is flashed instead of leaving the sidebar quietly empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_partitionsandlist_nodesonly checked thatsinfocould be spawned, so a controller that was down gave an empty list that looked exactly like a small cluster, andcheck_slurm_availablereturnedOkwhateversqueue --versionexited with. The three list calls now return aResultcarrying whatever the command printed, startup stops on a failingsqueue, and a probe that fails is flashed rather than leaving the sidebar quietly empty.list_qosgets the same treatment, so a cluster with no accounting database is no longer indistinguishable from asacctmgrthat failed.Closes #12