Skip to content

fix(progress): keep incomplete bodies below 100 percent - #99

Open
fedster99 wants to merge 1 commit into
mainfrom
fedster99/fix-body-progress-rounding
Open

fix(progress): keep incomplete bodies below 100 percent#99
fedster99 wants to merge 1 commit into
mainfrom
fedster99/fix-body-progress-rounding

Conversation

@fedster99

Copy link
Copy Markdown
Owner

Context

The row-accurate body progress view can report 100% for 199 fetched bodies out of 200 because PostgreSQL rounds 99.5 to 100. The account readiness fields and per-folder API field then make a false completion claim.

This blocks the downstream Signal body-coverage change from using these values as a reliable readiness signal.

Change

  • Append public migration 0023_exact_body_completion_percentages.
  • Floor incomplete live and priority account body ratios.
  • Apply the same exact-completion rule to per-folder current bodies_pct.
  • Preserve header and historical percentage behavior.
  • Add a real-Postgres 199/200 regression for priority, live, and folder progress.
  • Update the public schema manifest and contract documentation.

Verification

  • Red proof: Scenario R returned 100 for both live and priority at 199/200 before the fix.
  • Final INSTALL_CMD=true RUN_LIVE_DB=1 ./init.sh passed:
    • harness impact check
    • typecheck
    • 692 fast tests
    • API and web builds
    • 188 live-Postgres tests
    • 118/118 spec-conformance checks
  • Fresh read-only review found no blocking findings.
  • git diff --check passed.

The local shell used Node 26 and emitted the expected engine warning; the repository and CI pin Node 24.

Harness impact

Updated SESSION_HANDOFF.md, schema documentation, reliability invariants, the three-lane architecture guide, spec conformance, and ADR 0027. No CI, deployment, hook, or agent-control files changed.

Downstream

After human merge and immutable image publication, Signal must re-pin the public migrations, source SHA, image tag, and digest before its PR can finish.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
supamail Ready Ready Preview, Comment Jul 24, 2026 11:11am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant