fix(progress): keep incomplete bodies below 100 percent - #99
Open
fedster99 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The row-accurate body progress view can report 100% for 199 fetched bodies out of 200 because PostgreSQL rounds 99.5 to 100. The account readiness fields and per-folder API field then make a false completion claim.
This blocks the downstream Signal body-coverage change from using these values as a reliable readiness signal.
Change
0023_exact_body_completion_percentages.bodies_pct.Verification
INSTALL_CMD=true RUN_LIVE_DB=1 ./init.shpassed:git diff --checkpassed.The local shell used Node 26 and emitted the expected engine warning; the repository and CI pin Node 24.
Harness impact
Updated
SESSION_HANDOFF.md, schema documentation, reliability invariants, the three-lane architecture guide, spec conformance, and ADR 0027. No CI, deployment, hook, or agent-control files changed.Downstream
After human merge and immutable image publication, Signal must re-pin the public migrations, source SHA, image tag, and digest before its PR can finish.