Repository navigation
ndg-html: link custom scripts where they are copied - #298
Merged
Merged
Conversation
`copy_script_files` copies each script in `script_paths` to `assets/<file name>`, but the page linked the configured source path. A script from outside the output directory, such as a path in the Nix store, did not load. Link `assets/<file name>` instead. Assisted-by: Claude:claude-opus-5-5 Claude-Session: https://claude.ai/code/session_01RJvbghuj5GtCBiCjmBepNJ
NotAShelf
added a commit
that referenced
this pull request
Oct 4, 2026
…ying Followup for #298 Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I44546890ee0af5986ee2c7cd871a64be6a6a6964
NotAShelf
added a commit
that referenced
this pull request
Oct 4, 2026
…ying Followup for #298 Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I44546890ee0af5986ee2c7cd871a64be6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy_script_filescopies each script inscript_pathstoassets/<file name>. Butgenerate_custom_scriptslinked the configured source path, with the root prefix in front. A script from outside the output directory, such as/nix/store/<hash>-scripts/custom.js, then got a link that does not resolve, so the script did not load.This change links
{root_prefix}assets/<file name>, the same name thatcopy_script_filesuses.crates/ndg-html/tests/custom_scripts.rs. It fails before the change and passes after.CHANGELOG.md.We found this when we added Mermaid diagrams to a site built with ndg: we give a small loader script through
script_paths.Assisted-by: Claude:claude-opus-5-5
https://claude.ai/code/session_01RJvbghuj5GtCBiCjmBepNJ