Skip to content

ndg-templates: avoid reparenting option cards while filtering - #303

Merged
NotAShelf merged 2 commits into
feel-co:mainfrom
karol-broda:fix/options-filter-performance
Oct 7, 2026
Merged

NotAShelf merged 2 commits into
feel-co:mainfrom
karol-broda:fix/options-filter-performance

Conversation

@karol-broda

Copy link
Copy Markdown
Contributor

i noticed the options filter lagging on hjem’s docs with 1password enabled. the firefox profile showed the extension spending hundreds of milliseconds scanning cards after the filter removed and reinserted them

the filter now leaves cards in place and toggles hidden when needed. this means results stay in their original order. keyboard navigation skips hidden cards

checked that the same options match as before. all 31 javascript tests and lint pass

@NotAShelf NotAShelf changed the title fix(templates): avoid reparenting option cards while filtering ndg-templates: avoid reparenting option cards while filtering Oct 6, 2026
@NotAShelf

Copy link
Copy Markdown
Member

Could you add a changelog entry so that the check succeeds?

@NotAShelf

Copy link
Copy Markdown
Member

FYI we don't actually use conventional commits for this repository. I'm going to squash merge the changes since they're small enough, but please keep that in mind for future PRs.

Thank you for the good work :)

@NotAShelf
NotAShelf merged commit cf812ff into feel-co:main Oct 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants