Repository navigation
ndg-templates: avoid reparenting option cards while filtering - #303
Merged
NotAShelf merged 2 commits intoOct 7, 2026
Merged
Conversation
Member
|
Could you add a changelog entry so that the check succeeds? |
Member
|
FYI we don't actually use conventional commits for this repository. I'm going to squash merge the changes since they're small enough, but please keep that in mind for future PRs. Thank you for the good work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i noticed the options filter lagging on hjem’s docs with 1password enabled. the firefox profile showed the extension spending hundreds of milliseconds scanning cards after the filter removed and reinserted them
the filter now leaves cards in place and toggles
hiddenwhen needed. this means results stay in their original order. keyboard navigation skips hidden cardschecked that the same options match as before. all 31 javascript tests and lint pass