Repository navigation
ndg-templates: add Ctrl+K search shortcut and keycap hint - #304
Open
karol-broda wants to merge 2 commits into
Open
karol-broda wants to merge 2 commits into
karol-broda wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds Ctrl+K to focus search, alongside the existing
/shortcut. i didn’t even realise/already worked because vimium was catching itCtrl+K focuses the options filter when present, then the search page input, then the header search. it also works from editable fields, while
/still only activates outside themthe header search field now shows a Ctrl+K keycap, hidden while focused and on mobile. the search page's keyboard hints also list both shortcuts
i also noticed some weird things in the theming implementation while looking through this. happy to follow up with a separate PR for those if that would be welcome