Add an Enter-to-queue, Cmd/Ctrl+Enter-to-steer follow-up mode - #11
Draft
felipeorlando wants to merge 1 commit into
Draft
felipeorlando wants to merge 1 commit into
felipeorlando wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
Adds a third
queue-steerfollow-up mode. While a turn runs: Enter queues, ⌘+Enter (macOS) / Ctrl+Enter steers. Idle sessions send normally on both. Shift+Enter still inserts a newline. The existing Queue-only and Steer-only modes are unchanged.The keyboard intent flows through the existing submit path — no second queue implementation. Decision logic lives in two pure helpers in the new
src/lib/followUp.ts:isSteerShortcut(event, isMac)andresolveFollowUpAction(behavior, steerShortcut).App.tsxresolves the action at submit time;intent === "plan"still forces queue, and explicitfollowUpBehavior: "steer"callers (queued-row Steer, resume-queue) are unaffected.Needs careful review
isComposingguard was added — the upstream IME bug (Composer sends the message when Enter is pressed to commit IME composition (CJK input) hardbeat920/monocode#105) is out of scope, and guarding here would change behavior beyond this issue. Worth exercising with CJK input before merging.Verification
npm run check:web— exit 0, 128 files / 1331 tests.tsc --noEmitclean. 7 new tests for the helpers, plus a persistence round-trip test.No Composer render test — the repo has no React Testing Library setup for it.