Repository navigation
Enable confirmed coding commands and reliable client tool lifecycles - #679
Merged
Merged
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminal's
local_shellpreviously emulated a few file commands, so a coding agent could not run builds or tests. Add explicit--shellnative execution with a separate confirmation for every command, including under--yes, validated initial cwd, bounded output, deadlines, process-group cancellation and retained diagnostics. Add terminal file viewing through the pager.Make client-tool execution reliable across Stop, timeouts and later turns: cancel underlying browser mutations, pin mount identity, abort staged writable streams, scope request deduplication to a run, and prevent late callbacks from changing a newer turn. A pending local command no longer causes false heartbeat-stall recovery, and explicit command failures remain failures on the transcript card and upstream.
Browser emulation now reports unsupported commands as errors and handles compact echo redirection. Document the companion
codeagent, repair JSX type resolution after a clean pnpm install using the already locked React types, and make the finished-turn render test wait for actual stream completion. Contract snapshots retain the same vocabulary with refreshed source provenance.Validation
Runtime boundaries
--shellis Unix-specific and noninteractive. Its initial cwd is contained, but an approved command has the user's account access and is not sandboxed. Browser cancellation stops later mutation steps and aborts staged file writes; it does not roll back already committed changes. Live vendor behavior and a separate Postgres/Redis-backed API/worker deployment were not exercised.Companion
Felix code-agent manifest and reusable real-stack terminal smoke: felix-run/felix#775