Skip to content

Enable confirmed coding commands and reliable client tool lifecycles - #679

Merged
blakebauman merged 1 commit into
mainfrom
feat/code-tui
Nov 14, 2026
Merged

blakebauman merged 1 commit into
mainfrom
feat/code-tui

Conversation

@blakebauman

@blakebauman blakebauman commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

The terminal's local_shell previously emulated a few file commands, so a coding agent could not run builds or tests. Add explicit --shell native execution with a separate confirmation for every command, including under --yes, validated initial cwd, bounded output, deadlines, process-group cancellation and retained diagnostics. Add terminal file viewing through the pager.

Make client-tool execution reliable across Stop, timeouts and later turns: cancel underlying browser mutations, pin mount identity, abort staged writable streams, scope request deduplication to a run, and prevent late callbacks from changing a newer turn. A pending local command no longer causes false heartbeat-stall recovery, and explicit command failures remain failures on the transcript card and upstream.

Browser emulation now reports unsupported commands as errors and handles compact echo redirection. Document the companion code agent, repair JSX type resolution after a clean pnpm install using the already locked React types, and make the finished-turn render test wait for actual stream completion. Contract snapshots retain the same vocabulary with refreshed source provenance.

Validation

  • Shared client: 448 tests passed.
  • Browser workspace: 210 tests passed.
  • Web chat: 1,659 tests passed.
  • TUI: 386 tests passed.
  • Client, browser, TUI and web TypeScript checks; Biome; web and TUI builds; API drift, protocol parity and payload-shape checks passed.
  • Web first-load bundle: 447.7 kB gzipped, within the 450 kB budget.
  • Built TUI tested in a PTY against the real Felix HTTP API, compiler, approvals and durable fiber loop: both confirmations honored, file content and result delivery verified, final answer displayed, clean exit; two scripted model calls and no vendor calls.

Runtime boundaries

--shell is Unix-specific and noninteractive. Its initial cwd is contained, but an approved command has the user's account access and is not sandboxed. Browser cancellation stops later mutation steps and aborts staged file writes; it does not roll back already committed changes. Live vendor behavior and a separate Postgres/Redis-backed API/worker deployment were not exercised.

Companion

Felix code-agent manifest and reusable real-stack terminal smoke: felix-run/felix#775

@blakebauman
blakebauman merged commit 3a94117 into main Nov 14, 2026
1 check passed
@blakebauman
blakebauman deleted the feat/code-tui branch November 14, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant