chore: adopt nox + warden + nox-remediate (bootstrap CI + security)#1
Merged
Conversation
This repo had no CI and no dependency automation. Bootstrap the felixgeelhaar engineering bar from scratch: - .github/workflows/ci.yml — first CI for this repo; calls the central reusable felixgeelhaar/.github go-ci.yml@main (gofmt, go vet, golangci-lint, race tests, build, nox security scan -> code scanning). Coverage gate stays default-off. All jobs verified green locally (gofmt clean, vet/build/tests pass with -race, golangci-lint v2.12.2 reports 0 issues). - .github/workflows/nox-remediate.yml — weekly (Mon 06:17 UTC) + manual dependency/action remediation via the central reusable; replaces dependabot. - .nox.yaml — security/dependency gate config. Full scan of the tree reports ZERO findings, so no baseline is needed yet. Excludes cover only generated, vendored, and prose/data artifacts (go.sum, scanner state, *.md, testdata, *.pb.go) — all first-party Go source incl. *_test.go is scanned. - .warden.yaml — local git gate. pre-commit: gofmt + govet; pre-push: rebase, gofmt, govet, race tests, build. golangci-lint omitted (no .golangci.yml). - .gitignore — ignore nox scan output (nox-results/, findings.json, *.sarif). GitHub automated-security-fixes disabled in favor of nox-remediate. Claude-Session: https://claude.ai/code/session_01XsciE5KjxtMrHimxWxBVFS
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: {} | ||
| permissions: | ||
| contents: write |
| on: | ||
| push: {branches: [main]} | ||
| pull_request: {branches: [main]} | ||
| concurrency: {group: "${{ github.workflow }}-${{ github.ref }}", cancel-in-progress: true} |
| on: | ||
| schedule: | ||
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: {} |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| on: | ||
| schedule: | ||
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: {} |
There was a problem hiding this comment.
🔵 low IAC-308
GHA manual workflow dispatch enabled
| on: | ||
| push: {branches: [main]} | ||
| pull_request: {branches: [main]} | ||
| concurrency: {group: "${{ github.workflow }}-${{ github.ref }}", cancel-in-progress: true} |
There was a problem hiding this comment.
🔵 low IAC-309
GHA cancels in-progress runs (verify intent)
| - cron: "17 6 * * 1" | ||
| workflow_dispatch: {} | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
🟡 medium IAC-314
GHA workflow has contents write permission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bootstraps CI and supply-chain security for decisionkit, which previously had no
.github/workflows/and no dependabot. Mirrors the nox/warden shapes adopted across the org (ref:felixgeelhaar/preflight#128), adapted to this repo.Changes
.github/workflows/ci.yml(NEW — first CI for this repo) — calls the central reusablefelixgeelhaar/.github/.github/workflows/go-ci.yml@main: gofmt,go vet, golangci-lint, race tests,go build, and a nox security scan (SARIF → code scanning) with source-to-sink taint SAST. Go version auto-detected fromgo.mod(1.26.2). Coverage gate stays default-off.push/pull_requestonmain; concurrency-cancel..github/workflows/nox-remediate.yml(NEW) — weekly (17 6 * * 1) +workflow_dispatch; calls the centralnox-remediate.yml@mainreusable withsecrets: inherit. Replaces dependabot for dependency + GitHub Actions pin remediation..nox.yaml(NEW) — security/dependency gate config. A full nox 1.7.1 scan of the tree reports zero findings, so no baseline is needed yet. Path-excludes cover only generated/vendored/prose/data artifacts (go.sum, scanner state,*.md,testdata/,*.pb.go); all first-party Go source including*_test.gois scanned..warden.yaml(NEW) — local git gate. pre-commit:gofmt+govet; pre-push:rebase,gofmt,govet,gotest(go test -race ./...),gobuild.golangci-lintintentionally omitted (repo ships no.golangci.yml).pr.enabled: false, risk thresholdsdiff_lines_high: 400/files_touched_high: 15..gitignore— ignore nox scan output (nox-results/,findings.json,*.sarif).Also: disabled GitHub automated-security-fixes (
DELETE .../automated-security-fixes) in favor of nox-remediate.Verification (local, before push)
gofmt -l .→ cleango vet ./...→ passgo build ./...→ passgo test -race ./...→ all 4 packages passgolangci-lint run ./...(v2.12.2, matching the reusable) → 0 issuesnox scan(pinned 1.7.1) → 0 findingsDo not merge until CI is green.
https://claude.ai/code/session_01XsciE5KjxtMrHimxWxBVFS