chore(deps): bump vite-plus to pkg-pr-new PR #1703#6
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm-workspace.yaml file to use specific pre-release package URLs from pkg.pr.new in both the catalog and overrides sections, and configures release age exclusions. A critical issue was identified where the catalog definitions use PR-based versions (e.g., @1703) while the overrides use commit-hash-based versions. This inconsistency can lead to duplicate package installations and runtime issues, so it is recommended to align both sections to use the same commit hash specifier.
| vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703' | ||
| vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@1703' | ||
| vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703' |
There was a problem hiding this comment.
There is an inconsistency between the package versions specified in the catalog (which use the PR number @1703) and those in the overrides (which use the commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8).
Because pkg.pr.new serves these as different URLs, pnpm will treat them as distinct versions/packages. This can lead to duplicate installations of @voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test in the dependency graph, potentially causing runtime issues (e.g., broken instanceof checks or conflicting configurations).
Please align the catalog definitions to use the same commit hash specifier as the overrides.
vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8'
vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8'
vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8'
Summary
Bump
vite-plusand related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).Test plan