chore(deps): bump vite-plus to pkg-pr-new PR #1703#6
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates package.json to use a specific development version of vite-plus and modifies pnpm-workspace.yaml to add overrides, disable exotic subdependency blocking, and adjust the minimum release age settings. A critical issue was identified where the overrides field is defined in pnpm-workspace.yaml instead of the root package.json under pnpm.overrides, which will cause pnpm to ignore these overrides during dependency resolution.
| overrides: | ||
| '@voidzero-dev/vite-plus-core': https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8 | ||
| '@voidzero-dev/vite-plus-test': https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8 | ||
| '@voidzero-dev/vite-plus-prompts': https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8 | ||
| blockExoticSubdeps: false |
There was a problem hiding this comment.
In pnpm, the overrides field is not supported in pnpm-workspace.yaml. To ensure that these overrides are correctly applied by pnpm during dependency resolution, they should be defined in the root package.json under the pnpm.overrides field instead.
If these overrides are left in pnpm-workspace.yaml, pnpm will ignore them, which may lead to incorrect versions of @voidzero-dev/vite-plus-core, @voidzero-dev/vite-plus-test, and @voidzero-dev/vite-plus-prompts being resolved during installation.
You should move them to package.json like this:
"pnpm": {
"overrides": {
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8"
}
}blockExoticSubdeps: false
Summary
Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).
Test plan