Skip to content

chore(deps): bump vite-plus to pkg-pr-new PR #1703#6

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703
Draft

chore(deps): bump vite-plus to pkg-pr-new PR #1703#6
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures Bun's installation settings in bunfig.toml by adding minimumReleaseAge and an exclusion list. It also updates package.json to use prerelease versions of vite-plus and its core packages via pkg.pr.new URLs. The feedback points out that overriding vitest to @latest pulls the latest published version instead of the specific prerelease commit, and suggests pointing it directly to the correct prerelease URL to ensure consistency.

Comment thread package.json Outdated
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8",
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Overriding vitest to npm:@voidzero-dev/vite-plus-test@latest will pull the latest published version of @voidzero-dev/vite-plus-test from the npm registry, which does not contain the prerelease changes from commit d0b407c85b560c2470395176c9f1c838b5ca8af8. To ensure consistency and that the correct prerelease build is used, point vitest directly to the pkg.pr.new URL.

Suggested change
"vitest": "npm:@voidzero-dev/vite-plus-test@latest"
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8"

@fengmk2 fengmk2 changed the title chore(deps): bump vite-plus to pkg-pr-new PR #1703 (d0b407c) chore(deps): bump vite-plus to pkg-pr-new PR #1703 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant