Skip to content

chore(deps): bump vite-plus to pkg-pr-new PR #1703#13

Draft
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703
Draft

chore(deps): bump vite-plus to pkg-pr-new PR #1703#13
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).

Updated where applicable:

  • vite-plus
  • vitest (alias to @voidzero-dev/vite-plus-test)
  • vite (alias to @voidzero-dev/vite-plus-core)
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs
  • minimumReleaseAge configuration

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates pnpm-workspace.yaml to configure release age settings, update catalog dependencies to use pkg.pr.new URLs, and add package overrides. The reviewer identified critical configuration issues: .npmrc settings and the overrides block are incorrectly placed in pnpm-workspace.yaml where they will be ignored, and should be moved to .npmrc and the root package.json respectively. Additionally, the reviewer recommended aligning the dependency specifiers to consistently use either PR numbers or commit SHAs to prevent resolution issues.

Comment thread pnpm-workspace.yaml
Comment on lines +5 to +15
blockExoticSubdeps: false

minimumReleaseAge: 60
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
- "@oxc-project/*"
- "@oxlint/*"
- oxlint
- oxfmt
- oxlint-tsgolint

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The settings blockExoticSubdeps, minimumReleaseAge, and minimumReleaseAgeExclude are .npmrc configuration options, not valid fields for pnpm-workspace.yaml.

If defined here, they will be ignored by pnpm. This can cause the installation to fail because block-exotic-subdeps defaults to true in pnpm v10+ and will block exotic subdependencies (such as the pkg.pr.new URLs).

Please move these settings to the .npmrc file at the root of your project:

block-exotic-subdeps=false
minimum-release-age=60
minimum-release-age-exclude[]=vite-plus
minimum-release-age-exclude[]=@voidzero-dev/*
minimum-release-age-exclude[]=@oxc-project/*
minimum-release-age-exclude[]=@oxlint/*
minimum-release-age-exclude[]=oxlint
minimum-release-age-exclude[]=oxfmt
minimum-release-age-exclude[]=oxlint-tsgolint

Comment thread pnpm-workspace.yaml Outdated
Comment on lines +48 to +50
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8"
"@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8"
"@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In pnpm, the overrides field is not supported in pnpm-workspace.yaml. It must be defined in the root package.json under the pnpm.overrides key.

If defined in pnpm-workspace.yaml, these overrides will be ignored, which means transitive dependencies will not be overridden to the pkg.pr.new builds, potentially causing version mismatches and runtime/build errors.

Please move the overrides block to your root package.json:

"pnpm": {
  "overrides": {
    "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8",
    "@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8",
    "@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@d0b407c85b560c2470395176c9f1c838b5ca8af8",
    "vite": "catalog:",
    "vitest": "catalog:"
  }
}

Comment thread pnpm-workspace.yaml
Comment on lines +34 to +36
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1703
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The catalog definitions use the PR number (@1703), whereas the overrides (lines 48-50) use the specific commit SHA (@d0b407c85b560c2470395176c9f1c838b5ca8af8).

Mixing PR numbers and commit SHAs for the same packages can lead to inconsistent dependency resolution or duplicate package installations in pnpm if new commits are pushed to the PR. To ensure consistency and reproducibility, both the catalog and overrides should use the exact same specifier format (preferably the specific commit SHA).

  vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8

@fengmk2 fengmk2 changed the title chore(deps): bump vite-plus to pkg-pr-new PR #1703 (d0b407c) chore(deps): bump vite-plus to pkg-pr-new PR #1703 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant