Skip to content

chore(deps): bump vite-plus to pkg-pr-new PR #1703#6

Draft
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703
Draft

chore(deps): bump vite-plus to pkg-pr-new PR #1703#6
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates pnpm-workspace.yaml to use preview packages from pkg.pr.new for vite and vite-plus in the catalog, overrides several @voidzero-dev sub-dependencies with specific commit hashes, and configures release age exclusions. A review comment points out a mismatch between the PR-based version specifiers in the catalog and the commit-hash-based specifiers in the overrides, recommending alignment to prevent resolution conflicts.

Comment thread pnpm-workspace.yaml
Comment on lines +27 to +28
vite: "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703"
vite-plus: "https://pkg.pr.new/voidzero-dev/vite-plus@1703"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a mismatch between the version specifiers used in the catalog and the overrides. The catalog entries for vite and vite-plus use the PR number (@1703), while the overrides use the specific commit hash (@d0b407c85b560c2470395176c9f1c838b5ca8af8).\n\nTo avoid potential resolution conflicts, duplicate package downloads, or cache issues, it is highly recommended to use the exact same commit hash specifier for both the catalog and the overrides.

  vite: "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8"
  vite-plus: "https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8"

@fengmk2 fengmk2 changed the title chore(deps): bump vite-plus to pkg-pr-new PR #1703 (d0b407c) chore(deps): bump vite-plus to pkg-pr-new PR #1703 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant