-
Notifications
You must be signed in to change notification settings - Fork 345
feat(cli): publish agent skills from a declared docs.yml path #17751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matlegault
wants to merge
3
commits into
main
Choose a base branch
from
devin/1789492095-skills-declared-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
eb35724
feat(cli): publish agent skills from a declared docs.yml path (page-a…
matlegault ca4a84f
fix(cli): use async doesPathExist for well-known skills conflict check
matlegault 1d9e16b
fix(cli): parse skill markdown with mdast and share one manifest temp…
matlegault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
packages/cli/cli/changes/unreleased/feat-skills-declared-path.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| - summary: | | ||
| Agent skills can now be declared in docs.yml via `page-actions.options.skills.path`, | ||
| pointing at a directory of skills in the docs repo (resolved relative to the folder | ||
| containing docs.yml; `../` is allowed). At `fern generate --docs`, every subdirectory | ||
| containing a SKILL.md is published as one skill: the CLI validates the bundle | ||
| (kebab-case names matching directories, non-empty descriptions, unique names, no | ||
| references escaping a skill's directory), generates the `.well-known/skills/index.json` | ||
| discovery manifest, and uploads every file at `.well-known/skills/<name>/…` so that | ||
| `npx skills add https://<docs-domain>` works — without writing anything back to the | ||
| repo. A declared path wins over a hand-populated `fern/.well-known/skills/` folder | ||
| (warned on conflict); the raw well-known passthrough still applies when no path is | ||
| declared. | ||
| type: feat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟥 Skills path can expose host files
An absolute or escaping
skills.pathmakesdiscoverDeclaredSkillsread outside the repository. A matchingSKILL.mdlets publishing serve that directory's files publicly.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a trust boundary the CLI can enforce:
docs.ymlis authored by the same person who owns the repo and runsfern generate, and they can already publish any host file by copying it intofern/(or referencing it as an image).../is intentionally allowed so afern/docs.ymlcan point at a repo-root.agents/skills/shared with local coding agents, and clamping to the git root would break the monorepo case wherefern/and the skills live in different sub-packages. Publishing also requires aSKILL.mdwith valid frontmatter in every served directory, so accidentally pointing at/or~fails validation rather than uploading. Leaving as-is; happy to add a warning for absolute paths if reviewers want a nudge.