feat: integration tests for chat, image-gen, deploy + unit tests (#22)#29
Merged
Conversation
…parsing (closes #22) - Added integration tests for 3 missing skills: - TestDeployAgent: deploy inline code, verify in list, delete - TestChatAgent: structured output, timeout debug info - TestImageGenAgent: --search results, structured output - TestManageCleanup: cleanup subcommand validation - Added unit tests (tests/test_unit.py, 19 tests): - TestParseResultEntry: JSON, Python repr, UUID stripping, apostrophes, fallback - TestExtractResults: RESULT: extraction, ordering, empty cases - TestExtractStatus: status extraction, custom prefix, defaults - TestIsRelayAgent: relay name prefix matching - Unit tests skip gracefully when _common module is not present - Updated tests/README.md with full test inventory
8356611 to
1027ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive test coverage for the three skills that previously had zero tests (
agentverse-chat,agentverse-image-gen,agentverse-deploy), plus a new unit test file for offline testing of parsing functions.Closes #22.
Integration Tests Added (
tests/test_integration.py)TestDeployAgentTestChatAgentTestImageGenAgent--searchreturns agents; structured output from generationTestManageCleanupcleanupsubcommand returns structured JSONTotal integration tests: 8 existing + 6 new = 14 tests
Design Decisions
successandtimeout— computation quotas may prevent actual relay execution--cleanupto prevent relay agent accumulationtearDownUnit Tests Added (
tests/test_unit.py)TestParseResultEntryTestExtractResultsTestExtractStatusTestIsRelayAgentTotal unit tests: 19 tests — run offline, no API keys needed
Unit tests use
@unittest.skipUnless(HAS_COMMON_MODULE)to skip gracefully whenskills/_common/agentverse_relay.pyis not present (depends on PR #28).Files Changed
tests/test_integration.py— 6 new test methods across 4 new test classestests/test_unit.py— new file, 19 unit tests across 4 test classestests/README.md— updated with full test inventory, unit test instructions