fix(trip_planner): replace unsafe eval() in calculator tool with AST …#118
Open
sanjaysaini383 wants to merge 1 commit into
Open
fix(trip_planner): replace unsafe eval() in calculator tool with AST …#118sanjaysaini383 wants to merge 1 commit into
sanjaysaini383 wants to merge 1 commit into
Conversation
…math parser Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Hii @gautammanak1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical security issue in
Crewai-agents/trip_planner/tools/calculator_tools.pywhereCalculatorTools.calculatepassed LLM-controlled input to Pythoneval(), enabling arbitrary code execution (RCE).This PR replaces
eval()with a safe math evaluator that:+ - * / ( ) .ast.parse(..., mode="eval")Type of Change
Checklist
ruff check ..ruff format ..README.mdfor changed example(s). (Not required — behavior unchanged for valid math input; security fix only.).env.exampleif environment variables are required. (N/A)CHANGELOG.md(required for non-doc changes).Related Issue
Closes #111
Notes for Reviewers
Security
eval(operation)with full Python builtins__import__('os').system('id')executeValueError→ user-facing error stringFiles changed
Crewai-agents/trip_planner/tools/calculator_tools.py— core fixCHANGELOG.md— unreleased fix entryBehavior preserved
Valid examples from the tool docstring still work, e.g.
200*7→1400.0,5000/2*10→25000.0.